Differential D28588

Make sure MessageViewerSettings::self() is called before the base class one
ClosedPublic
Actions

Authored by vkrause on Apr 5 2020, 11:19 AM.

Details

Reviewers
mlaurent
dfaure
Commits
R94:0ae3bf5405cf: Make sure MessageViewerSettings::self() is called before the base class one
Summary

This is a dirty workaround and fixes akonadiconsole crashing on startup.
A proper solution would need a larger review of the settings handling
here I guess, ideally getting rid of the base-class self() method to
prevent this from happening in the first place.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 5 2020, 11:19 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 5 2020, 11:19 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 5 2020, 11:19 AM
mlaurent accepted this revision.Apr 5 2020, 11:53 AM
This revision is now accepted and ready to land.Apr 5 2020, 11:53 AM
Closed by commit R94:0ae3bf5405cf: Make sure MessageViewerSettings::self() is called before the base class one (authored by vkrause). · Explain WhyApr 5 2020, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79396

View Options

messageviewer/src/dkim-verify/dkimcheckpolicy.cpp

Loading...