Details
Details
- Reviewers
ervin - Commits
- R490:2af0169e4a7b: Make implicitly shared types movable
Diff Detail
Diff Detail
- Repository
- R490 KDAV Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/common/davcollection.cpp | ||
|---|---|---|
| 40–41 | Just realizing now but if they're all set to = default anyway, why not rely on the rule of zero and simply drop them all? | |
| src/common/daverror.cpp | ||
| 40–41 | Rule of zero candidate as well? | |
| src/common/daverror.h | ||
| 47 | KF style is to put the space before the & | |
| 50 | same here | |
| src/common/davitem.cpp | ||
| 36–37 | Rule of zero candidate? | |
| src/common/davurl.cpp | ||
| 34–35 | Rule of zero candidate? | |
| 38 | Space before & in KF style | |
| src/common/davurl.h | ||
| 39 | Space before & in KF style | |
| src/common/davcollection.cpp | ||
|---|---|---|
| 40–41 | Not an option here as this needs the private class to be fully defined. | |
| src/common/davcollection.cpp | ||
|---|---|---|
| 40–41 | Oh right... bummer... | |