Differential D2858

Fix Plasma discover with the Kirigami it can depend on
AbandonedPublic
Actions

Authored by davidedmundson on Sep 26 2016, 5:04 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Summary

At Plasma dependency freeze Discover depended on Kirigami 1.0.

That means it *has* to work on Kirigami 1.0.

It cannot then decide to use features from 1.1, just because it's released.
It's against all compatibility promises we make.

Test Plan

Tested discover loads again. Not tested the rest.

Diff Detail

Repository
R134 Discover Software Store
Branch
Plasma/5.8
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 6928.Sep 26 2016, 5:04 PM
davidedmundson retitled this revision from to Fix Plasma discover with the Kirigami it can depend on.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 26 2016, 5:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Sep 26 2016, 5:35 PM
apol added a reviewer: apol.
apol added a subscriber: apol.

Please also merge to master and revert the patch there.

This revision is now accepted and ready to land.Sep 26 2016, 5:35 PM
apol requested changes to this revision.Sep 26 2016, 7:53 PM
apol edited edge metadata.

Should be discarded, it's incompatible with another RR

This revision now requires changes to proceed.Sep 26 2016, 7:53 PM
davidedmundson abandoned this revision.Sep 27 2016, 9:47 AM

Revision Contents
Changeset List

Diff 6928

View Options

discover/qml/DiscoverDrawer.qml

Loading...
View Options

discover/qml/Separator.qml

Loading...
View Options

discover/resources.qrc

Loading...