Differential D28554

Add Smart TV UX as device type
ClosedPublic
Actions

Authored by Arucard on Apr 4 2020, 11:54 AM.

Details

Reviewers
None
Group Reviewers
KDE Human Interface Guidelines
Commits
R985:2a3dad6675a6: Add Smart TV UX as device type
Summary

In light of the Plasma Bigscreen shell it seemed useful to
have a device type for Smart TVs. The content is partially based on
this post from Marco Martin:
https://notmart.org/blog/2020/03/behind-plasma-bigscreen/

Some of the content is just a best-guess for the UX based on
screenshots of Plasma Bigscreen. So some parts may need to be
changed to better recommendations for an optimal UX.

Test Plan

I ran "make html" and verified the added content locally

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Arucard requested review of this revision.Apr 4 2020, 11:54 AM
Arucard created this revision.
Arucard edited the summary of this revision. (Show Details)Apr 4 2020, 11:59 AM
Arucard added a project: KDE Human Interface Guidelines.
Arucard added a comment.Apr 4 2020, 12:06 PM

As a side-note, I just wanted to mention that the Contribute section in the HIG doesn't actually explain how to submit the changes you make locally. I followed the instructions from this Community page. I'm not sure if this is correct and it actually took a bit of searching to find. So it might be useful to include up-to-date instructions on the Contribute page in the HIG, even if it's just a link to that same page (assuming that's the correct workflow to use).

ngraham added a subscriber: ngraham.Apr 9 2020, 10:04 PM

Sorry for the delayed review, and thanks very much for the patch! Also sorry for the poor documentation. I'll fix that. It needs to mention that patches for the HIG are submitted on GitLab, at https://invent.kde.org/websites/hig-kde-org/-/merge_requests. Would you mind re-submitting this patch over there? Thanks again!

Arucard added a comment.Apr 12 2020, 6:49 AM

Sorry for responding so late as well. I'll re-submit according to the instructions you provided.

ngraham added a comment.Apr 12 2020, 5:51 PM

Thank you! You can formally Abandon this now.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2020, 9:50 PM
Closed by commit R985:2a3dad6675a6: Add Smart TV UX as device type (authored by Arucard, committed by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.
Arucard added a comment.Apr 13 2020, 5:47 PM
In D28554#646620, @ngraham wrote:

Thank you! You can formally Abandon this now.

Is that something specific that I still need to do here? If so, how? I can't find anything that indicates setting this review to Abandoned status or something like that.

ngraham added a comment.Apr 13 2020, 6:38 PM

Oh interesting, Phab closed it automatically when I landed the GitLab version.

Arucard added a comment.Apr 14 2020, 7:02 AM

Seems to be because I still had the "Differential Revision" field in the commit message:

Commit Close Explanation
We found a "Differential Revision" field with value "28554" in the commit message, and the domain on the URI matches this install, so we linked this commit to D28554.

Seems like this is done then. Thanks for your help.

ngraham added a comment.Apr 14 2020, 4:32 PM

You're welcome!

Revision Contents
Changeset List

Diff 79965

View Options

HIG/source/introduction/devicetypes.rst

Loading...