Differential D28524

Fix build on LLVM < 8
ClosedPublic
Actions

Authored by christianschaerf on Apr 2 2020, 7:24 PM.

Details

Reviewers
smartins
Summary

The newly created overloaded-signals check uses the clang::Decl::getBeginLoc method, which was renamed from getLocStart in LLVM 8.
This patch changes this to use clazy::getLocStart, which dispatches between these methods depending on the LLVM version.

Diff Detail

Repository
R74 Clazy
Lint
Lint Skipped
Unit
Unit Tests Skipped
christianschaerf requested review of this revision.Apr 2 2020, 7:24 PM
christianschaerf created this revision.
smartins accepted this revision.Apr 13 2020, 10:43 AM

thanks, please push to 1.6 branch

This revision is now accepted and ready to land.Apr 13 2020, 10:43 AM
christianschaerf added a comment.Apr 19 2020, 10:28 AM
In D28524#647037, @smartins wrote:

thanks, please push to 1.6 branch

The overloaded-signal check is not present in 1.6, it was added afterwards

smartins closed this revision.Apr 19 2020, 8:18 PM

pushed, please close

Revision Contents
Changeset List

Diff 79166

View Options

src/checks/level0/overloaded-signal.cpp

Loading...