Differential D28481

Revert "Fix build with Qt 5.15"
ClosedPublic
Actions

Authored by apol on Apr 1 2020, 12:51 PM.

Details

Reviewers
broulik
Commits
R122:9dbae3f1c3d6: Revert "Fix build with Qt 5.15"
Summary

This reverts commit 3a5aca82527ec45d22d09e220ff3ff00a42971d2.

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 1 2020, 12:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 1 2020, 12:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Apr 1 2020, 12:51 PM
apol updated this revision to Diff 79043.Apr 1 2020, 12:59 PM

remove unrelated changes

apol added a comment.Apr 1 2020, 1:00 PM

commit 46ebd11e66f6f3180043a7258b46a1aff79a69f8
Author: Lars Knoll <lars.knoll@qt.io>
Date: Wed Mar 25 11:20:28 2020 +0100

Fix deprecation of QComboBox:::currentIndexChanged(const QString&)

Don't introduce another overload with two parameters. Users
want a simple signal to connect to, not another overload. Deprecate
the currentIndexChanged(QString) overload, usage of that can/should
get replaced by currentTextChanged().

This partially reverts commit 11dc7b35c8c3957bd19087a5e3ae7cfc4f1a3343.

Change-Id: I5e7d16413f3d62b1a5a7a197f510af2c45cdfa55
Reviewed-by: Vitaly Fanaskov <vitaly.fanaskov@qt.io>
broulik accepted this revision.Apr 1 2020, 1:18 PM

Thanks

This revision is now accepted and ready to land.Apr 1 2020, 1:18 PM
Closed by commit R122:9dbae3f1c3d6: Revert "Fix build with Qt 5.15" (authored by apol). · Explain WhyApr 1 2020, 2:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79050

View Options

daemon/actions/bundled/wirelesspowersavingconfig.cpp

Loading...