Differential D28465

[Categories Page] Use BasicListItem
AcceptedPublic
Actions

Authored by broulik on Mar 31 2020, 1:54 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Summary

The delegate doesn't have its own appearance anymore, so just use the default one.

Test Plan

Looks almost the same, might have lost the tablet mode spacing increase now?
Set label in any case for accessibility and it now inverts properly when selected

Before


After

Diff Detail

Repository
R124 System Settings
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 31 2020, 1:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2020, 1:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 31 2020, 1:54 PM
ngraham accepted this revision.Mar 31 2020, 1:59 PM
ngraham added a subscriber: ngraham.

Nice! Tablet mode spacing should just be added into BasicListItem itself, if it doesn't already have it.

This revision is now accepted and ready to land.Mar 31 2020, 1:59 PM
broulik added a comment.Mar 31 2020, 1:59 PM

Tablet mode spacing should just be added into BasicListItem itself

Agreed. I was surprised it didn't actually come from it but was done here explicitly

Revision Contents
Changeset List

Diff 78989

View Options

sidebar/package/contents/ui/CategoriesPage.qml

Loading...