[TodoView] Use parents collection when creating a subtodo
ClosedPublic

Authored by poboiko on Mar 30 2020, 1:07 PM.

Details

Summary

When creating a subtodo of an existing task, it should belong to the same collection.

Apparenly, there was a typo: parent collection was determined, but not passed to createIncidence call.
Just fix it.

Test Plan
  1. Open KOrganizer todo list, select an existing todo
  2. Enter new todo description in the text widget below the list, press Ctrl+Enter
  3. (without patch) It asks for a collection despite attempting to create a sub-todo
  4. (with patch) A sub-todo gets created in the same collection

Diff Detail

Repository
R76 PIM: Event Views
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poboiko created this revision.Mar 30 2020, 1:07 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 30 2020, 1:07 PM
poboiko requested review of this revision.Mar 30 2020, 1:07 PM
winterz accepted this revision.Mar 30 2020, 1:20 PM
winterz added a subscriber: winterz.

I think there's a bug for this one.
Maybe https://bugs.kde.org/show_bug.cgi?id=409972 ?

please put this in the release/20.04 branch and then merge to master

This revision is now accepted and ready to land.Mar 30 2020, 1:20 PM

I think there's a bug for this one.
Maybe https://bugs.kde.org/show_bug.cgi?id=409972 ?

Hmm, I'm not sure about this one.
As far as I understood, the bug is about creating an event-related Todo from menu from Calendar View (which in principle could be created in any calendar). And I wasn't able to reproduce it.
This patch, however, is for creating a sub-to-do using Todo View (which should go to the same calendar).
I've looked through bugzilla (keyword "todo" / "sub todo" / "parent todo"), didn't find related bugs...

This revision was automatically updated to reflect the committed changes.