Differential D28176

Implement Keyboard Keycode support as suggested in the spec
ClosedPublic
Actions

Authored by apol on Mar 21 2020, 1:31 AM.

Details

Reviewers
jgrulich
Commits
R838:cdd01df4e539: Implement Keyboard Keycode support as suggested in the spec
Summary

Makes it possible to send keyboard events

Test Plan

Used it with my joyclick test app

Diff Detail

Repository
R838 Flatpak Support: KDE Portal for XDG Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mar 21 2020, 1:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 21 2020, 1:31 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Mar 21 2020, 1:31 AM
jgrulich accepted this revision.Mar 21 2020, 12:28 PM

I thought I already had support for this, maybe it got lost somewhere. Looks good otherwise.

src/waylandintegration.cpp
386

Nitpick, I use brackets even for ifs with one line of code so if you would be so kind and use brackets to have same coding style.

This revision is now accepted and ready to land.Mar 21 2020, 12:28 PM
apol added a comment.Mar 21 2020, 3:48 PM

It was in kwin, I guess we forgot to get it in the portal.

Closed by commit R838:cdd01df4e539: Implement Keyboard Keycode support as suggested in the spec (authored by apol). · Explain WhyMar 21 2020, 3:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78168

View Options

src/remotedesktop.cpp

Loading...
View Options

src/waylandintegration.h

Loading...
View Options

src/waylandintegration.cpp

Loading...
View Options

src/waylandintegration_p.h

Loading...