Differential D2814

Make sure to animate proper containments
ClosedPublic
Actions

Authored by mart on Sep 19 2016, 3:39 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:49131300b7e8: Make sure to animate proper containments
Summary

if the activity is changed again while the switch animation
is being performed, the desktop finds itself in an
inconsistent state, as oldContainment and newContainment
values gets changed while the animation is running.
this makes sure the animation is stopped and all the values
are resetted if the containment changes before the anim is done

BUG:352345

Test Plan

tried with the animation made really slow, was easy to reproduce 352345, then the problem went away with the patch

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 6818.Sep 19 2016, 3:39 PM
mart retitled this revision from to Make sure to animate proper containments.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptSep 19 2016, 3:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart edited the test plan for this revision. (Show Details)Sep 19 2016, 3:41 PM
mart added a reviewer: Plasma.
davidedmundson accepted this revision.Sep 19 2016, 4:25 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Sep 19 2016, 4:25 PM
Closed by commit R119:49131300b7e8: Make sure to animate proper containments (authored by mart). · Explain WhySep 19 2016, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6819

View Options

desktoppackage/contents/views/Desktop.qml

Loading...