Differential D28073

[kstyle] Properly unregister widgets in ShadowHelper
ClosedPublic
Actions

Authored by zzag on Mar 16 2020, 1:18 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R113:19771d84177d: [kstyle] Properly unregister widgets in ShadowHelper
Summary

After a widget has been unregistered, a WinIdChange event may be sent.
If that happens, ShadowHelper is going to try to install a shadow for
the corresponding widget. Obviously, this is wrong.

Test Plan

Added a qDebug in ~ShadowHelper to ensure that _shadows is
empty.

Diff Detail

Repository
R113 Oxygen Theme
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 16 2020, 1:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 16 2020, 1:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Mar 16 2020, 1:18 PM
zzag added a comment.Mar 16 2020, 1:34 PM
This comment was removed by zzag.
broulik accepted this revision.Mar 18 2020, 10:06 AM
This revision is now accepted and ready to land.Mar 18 2020, 10:06 AM
Closed by commit R113:19771d84177d: [kstyle] Properly unregister widgets in ShadowHelper (authored by zzag). · Explain WhyMar 18 2020, 10:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstyle/oxygenshadowhelper.cpp (11 lines)

Diff 77892

View Options

kstyle/oxygenshadowhelper.cpp

Loading...