Differential D28022

Fallback to a simple rectangle when using software rendering
ClosedPublic
Actions

Authored by ahiemstra on Mar 13 2020, 11:28 AM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Commits

R169:4fd45c1cc7fd: Fallback to a simple rectangle when using software rendering

Summary

If the scene graph is using software rendering, the custom shaders used for
ShadowedRectangle will not work. So in that case, create a simple rectangle
node and use that. This loses a bunch of features of the item but at least
shows something.

Test Plan

ShadowedRectangleTest with QT_QUICK_BACKEND=software set renders a rectangle.

Diff Detail

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ahiemstra created this revision.Mar 13 2020, 11:28 AM

Restricted Application added a project: Kirigami. · View Herald TranscriptMar 13 2020, 11:28 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ahiemstra requested review of this revision.Mar 13 2020, 11:28 AM

Harbormaster completed remote builds in B23650: Diff 77549.Mar 13 2020, 11:28 AM

Use QQuickPaintedItem to render a rect with rounded corners and border

Harbormaster completed remote builds in B23656: Diff 77556.Mar 13 2020, 1:37 PM

mart accepted this revision.Mar 13 2020, 3:25 PM

This revision is now accepted and ready to land.Mar 13 2020, 3:25 PM

Closed by commit R169:4fd45c1cc7fd: Fallback to a simple rectangle when using software rendering (authored by ahiemstra). · Explain WhyMar 13 2020, 3:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (1 line)
A	M	src/scenegraph/paintedrectangleitem.h (43 lines)
A	M	src/scenegraph/paintedrectangleitem.cpp (50 lines)
M		src/shadowedrectangle.h (5 lines)
M		src/shadowedrectangle.cpp (35 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	77549	404e054		Mar 13 2020, 11:28 AM	★	★
Diff 2	77556	404e054	- Use QQuickPaintedItem to render a rect with rounded corners and border	Mar 13 2020, 1:37 PM	★	★
Diff 3	77576	fe9073e	R169:4fd45c1cc7fdc5d42c6451441b9194594d8fa57f	Mar 13 2020, 3:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
99107bcdabbf	c00984b63ead	ee3da9f1d32b	Arjen Hiemstra	Use QQuickPaintedItem to render a rect with rounded corners and border	Mar 13 2020, 1:37 PM
ee3da9f1d32b	553b14125cbe	404e05452b79	Arjen Hiemstra	Fallback to a simple rectangle when using software rendering (Show More…)	Mar 13 2020, 11:25 AM