libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe
ClosedPublic

Authored by maxrd2 on Mar 10 2020, 3:21 PM.

Details

Summary

libs/lapack: added 3.9.0 recipe
libs/sphinxbase: added recipe
libs/pocketsphinx: added recipe

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
maxrd2 requested review of this revision.Mar 10 2020, 3:21 PM
maxrd2 created this revision.

libs/lapack requires gfortran compiler, am not sure whether additional steps are required or if it's there by default.

libs/sphinxbase might need libpulse.so on linux... that one should be shipped already or do I need to create another package?

In general we should try to use tarballs instead of unstable branches

libs/lapack/lapack.py
12

could you add a inline comment with the source of the patch :)

libs/pocketsphinx/pocketsphinx.py
23

why? how is it broken :)

libs/sphinxbase/sphinxbase.py
23

see above

28

you could just use python :)

maxrd2 marked an inline comment as done.Mar 10 2020, 3:39 PM
maxrd2 added inline comments.
libs/pocketsphinx/pocketsphinx.py
23

It runs configure in source dir, and afterwards configure fails in build dir complaining about needing to run make distclean in source dir.
Have managed to workaround it by including call to make distclean before running configure, but that involved rewriting whole configure() and not calling super().configure().

libs/sphinxbase/sphinxbase.py
28

Instead of sed?
Am not too fluent in python :( Will look it up.

maxrd2 updated this revision to Diff 77358.Mar 10 2020, 3:41 PM

libs/lapack: added patch origin

In general we should try to use tarballs instead of unstable branches

Will change it to use tarball of certain commit so build doesn't break with time.
Should I also created 3 separate diffs.. one for each recipe?

maxrd2 updated this revision to Diff 77362.Mar 10 2020, 4:23 PM

libs/sphinxbase: switched to tarball, included autogen.sh
libs/pocketsphinx: switched to tarball, included autogen.sh

maxrd2 marked an inline comment as done.Mar 10 2020, 4:33 PM
maxrd2 added inline comments.
libs/pocketsphinx/pocketsphinx.py
23

there are no issues when using tarball, so have removed it

libs/sphinxbase/sphinxbase.py
23

there are no issues when using tarball, so have removed it

maxrd2 marked 5 inline comments as done.Mar 10 2020, 4:34 PM
maxrd2 updated this revision to Diff 77374.Mar 10 2020, 7:27 PM

replaced sed command with python regexp code

maxrd2 added inline comments.Mar 10 2020, 7:29 PM
libs/sphinxbase/sphinxbase.py
28

is it better/good like this?

vonreth requested changes to this revision.Mar 18 2020, 2:12 PM
vonreth added inline comments.
libs/pocketsphinx/pocketsphinx.py
28

use rt and wt to use text mode instead of binary mode

or was binary mode needed?

libs/pocketsphinx/version.ini
7

revisions should be used as branches I guess, for tarballs see https://sourceforge.net/projects/cmusphinx/files/

libs/sphinxbase/sphinxbase.py
30

same^

libs/sphinxbase/version.ini
8

revisions should be used as branches I guess, for tarballs see https://sourceforge.net/projects/cmusphinx/files/sphinxbase/

This revision now requires changes to proceed.Mar 18 2020, 2:12 PM
maxrd2 updated this revision to Diff 77948.Mar 18 2020, 6:10 PM
This comment was removed by maxrd2.
maxrd2 updated this revision to Diff 77953.Mar 18 2020, 6:13 PM

Changed streams to use text mode

maxrd2 marked 2 inline comments as done.Mar 18 2020, 6:24 PM
maxrd2 added inline comments.
libs/pocketsphinx/version.ini
7

Sourceforge sources haven't been updates since 2016... project home is on github now.
Those tarballs are outdated.

libs/sphinxbase/version.ini
8

Same as above. Sourceforge tarballs are outdated.

vonreth accepted this revision.Mar 23 2020, 10:50 AM

Well I have to trust you with the tarballs

This revision is now accepted and ready to land.Mar 23 2020, 10:50 AM
This revision was automatically updated to reflect the committed changes.