Remove use of QLinkedList
ClosedPublic
Actions

Authored by apol on Mar 8 2020, 8:05 PM.

Details

Reviewers

mlaurent
kossebau

Commits

R455:647982c2bc3e: Remove use of QLinkedList

Summary

Uses QList instead which is not yet deprecated

Repository

R455 KompareDiff2 Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol requested review of this revision.Mar 8 2020, 8:05 PM

apol created this revision.

komparemodellist.cpp
1071–1072	Not having looked further, but `lines` could be directly starting off by taking the result of that `split()` call, instead of manually copying the list, no?
1072–1073	IMHO `auto` is fine as type for iterators variables.

mlaurent requested changes to this revision.Mar 9 2020, 5:45 AM

mlaurent added inline comments.

komparemodellist.cpp
1071–1072	yep indeed.

This revision now requires changes to proceed.Mar 9 2020, 5:45 AM

Simplify code

This revision is now accepted and ready to land.Mar 9 2020, 4:21 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			komparemodellist.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	77237	87a4875		Mar 8 2020, 8:05 PM	★	★
Diff 2	77283	87a4875	Simplify code	Mar 9 2020, 3:03 PM	★	★
Diff 3	77296	87a4875	R455:647982c2bc3e55afd48cbd89b9767e2d7aeced1c	Mar 9 2020, 4:24 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9b67691961d0	2282915d6180	87a48751695e	Aleix Pol	Remove use of QLinkedList (Show More…)	Mar 8 2020, 8:04 PM