[plasma-session] Continue to start kdeinit

Authored by davidedmundson on Mar 5 2020, 1:49 PM.



This was a deliberate decision to remove this in

The logic being that kdeinit should auto launch itself if required.

In practice this exposes a presumably pre-existing bug in kdeinit
autostarting where the env is not set correctly.

Test Plan

qdbus org.kde.klauncher5 /KLauncher org.kde.KLauncher.exec_blind /opt/kde5/bin/kate ""

kate opened

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Mar 5 2020, 1:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2020, 1:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 5 2020, 1:49 PM

I kinda feel this is a bodge fix and we should find what's wrong with whoever is autoactivating kdeinit, but I don't like leaving master with a regression.

So I'll let someone else decide if we accept this or not.

broulik accepted this revision.Mar 5 2020, 2:13 PM
broulik added a subscriber: broulik.

Fixes thumbnail generation and other issues for me.

Short-term this is fine. But since this kdeinit stuff is layered in wrappers upon wrappers I think getting rid of it entirely is a better mid-term goal than trying to port it to proper dbus-activation.

This revision is now accepted and ready to land.Mar 5 2020, 2:13 PM
This revision was automatically updated to reflect the committed changes.