Differential D27822

Introduce AbstractClient::createDecoration()
ClosedPublic
Actions

Authored by zzag on Mar 4 2020, 8:22 AM.

Details

Reviewers

apol

Group Reviewers

KWin

Commits

R108:4ae6c99c6bc4: Introduce AbstractClient::createDecoration()

Summary

We have duplicated code in InternalClient and XdgShellClient to create
decorations. In order to get rid of the code duplication, this change
introduces a method that AbstractClient subclasses can call to create
a window decoration.

Test Plan

Tests pass.

Diff Detail

Repository

R108 KWin

Lint

Lint Skipped

Excuse: foobar

Unit

No Unit Test Coverage

Build Status

Buildable 23237
Build 23255: arc lint + arc unit

zzag created this revision.Mar 4 2020, 8:22 AM

Restricted Application added a project: KWin. · View Herald TranscriptMar 4 2020, 8:22 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Mar 4 2020, 8:22 AM

Harbormaster completed remote builds in B23225: Diff 76903.Mar 4 2020, 8:22 AM

zzag added a dependency: D27821: Introduce AbstractClient::destroyClient().Mar 4 2020, 8:22 AM

Don't pass ForceGeometrySet

We know for sure that the frame geometry will change.

Harbormaster completed remote builds in B23237: Diff 76916.Mar 4 2020, 10:43 AM

+1 looks good!

abstract_client.cpp
2146	We are not capturing anything, reads like it could be a normal slot.

zzag added inline comments.Mar 4 2020, 12:23 PM

abstract_client.cpp
2146	I just copied createDecoration() from xdgshellclient.cpp and tweaked coding style a little bit. Do I need to change something?

apol accepted this revision.Mar 4 2020, 11:58 PM

This revision is now accepted and ready to land.Mar 4 2020, 11:58 PM

Closed by commit R108:4ae6c99c6bc4: Introduce AbstractClient::createDecoration() (authored by zzag). · Explain WhyMar 5 2020, 8:36 AM

This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.cpp (21 lines)
M			x11client.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76903	ece452d		Mar 4 2020, 8:22 AM	★	★
Diff 2	76916	6a51946	Don't pass ForceGeometrySet	Mar 4 2020, 10:43 AM	★	★
Diff 3	76993	17e6bd8	R108:4ae6c99c6bc45293800af4f6387e1bd06dca063f	Mar 5 2020, 8:25 AM	★	★

Introduce AbstractClient::createDecoration()ClosedPublicActions

Details

Diff Detail

Showing Only Differences

Revision ContentsChangeset List

Diff 76916

abstract_client.cpp

x11client.h

Introduce AbstractClient::createDecoration()
ClosedPublic
Actions

Revision Contents
Changeset List