KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header
ClosedPublic

Authored by kossebau on Mar 3 2020, 10:02 PM.

Diff Detail

Repository
R249 KI18n
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Mar 3 2020, 10:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 3 2020, 10:02 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Mar 3 2020, 10:02 PM

Ping?

I have seen a few projects having CMAKE_AUTOUIC set to ON, due to copy-pasted cmake code, or having converted to ki18n only during development. So let's help them to avoid unneeded file generation while they are finding the cmake skills. And this would also assist bigger projects where some parts use ki18n, others might not. so being able to set the default globally by CMAKE_AUTOUIC to ON would be nice, and have those UI files being opted out where the macro is used.

While the autouic-generated headers seem currently shadowed, because the include path ${target}_autogen/include is being passed only after the include path of the current build directory, where the k18n_wrap-ui files puts the generated headers, to the compiler, so final build executables are not having any issues, this still is a bit fragile. And eats disk space and grows dependency ruiles and build time minimally. So better be safe.

BTW, qt5_wrap_ui sets SKIP_AUTOUIC as well on those files.

If no-one objects, going to push upcoming WE then, April 18/19

This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2020, 10:01 PM
This revision was automatically updated to reflect the committed changes.