This way, we get a more fluid scrolling behavior. Previously, the
two values got set somewhat randomly - I couldn't figure out the
logic behind it. Most notably, both values where set to very large
values, sometimes in excess of 1000, which lead to the jumpy scrolling
behavior previously.
Details
Details
Diff Detail
Diff Detail
- Repository
- R865 Ruqola
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/widgets/room/messagelistview.cpp | ||
|---|---|---|
| 60 | Still feels jumpy to me. verticalScrollBar()->setSingleStep(fontMetrics().height() + 10); works nicely here (both Key_Up and mousewheel), and has the benefit of looking less hardcoded (the 10 is an approx of the margins used by the delegate, 8+3 iirc) | |
| src/widgets/room/messagelistview.cpp | ||
|---|---|---|
| 61 | I'm wondering if this should be set to the viewport height? That is the "page", visually... | |
| src/widgets/room/messagelistview.cpp | ||
|---|---|---|
| 61 | good idea, though imo it should be half a page, or 3/4 of a page to not lose context. kate also doesn't scroll the full page while scrolling | |
| src/widgets/room/messagelistview.cpp | ||
|---|---|---|
| 61 | OK, I'm happy if we do something similar to what kate does indeed. | |
Comment Actions
git fail, accidentally pushed this too early - will implement the page fix on top now and push it directly