Make support for taking focus opt-in
AbandonedPublic
Actions

Authored by zzag on Mar 2 2020, 11:12 AM.

Details

Reviewers

None

Group Reviewers

Summary

In long term, we want to split XdgShellClient into several classes. One
for xdg-toplevel role, and the other one for xdg-popup role. This change
makes the ability to take focus opt-in because it is not applicable to
popups.

Diff Detail

Repository

R108 KWin

Lint

Lint Skipped

Excuse: foo

Unit

No Unit Test Coverage

Build Status

Buildable 23139
Build 23157: arc lint + arc unit

zzag created this revision.Mar 2 2020, 11:12 AM

Restricted Application added a project: KWin. · View Herald TranscriptMar 2 2020, 11:12 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Mar 2 2020, 11:12 AM

Harbormaster completed remote builds in B23139: Diff 76763.Mar 2 2020, 11:12 AM

This patch doesn't change anything as far as I can tell. It just moves the default implementation to its parent. Not that there's anything wrong with it, but the commit message reads as if it was supposed to do something.

apol mentioned this in D27779: Make support for move/resize operations opt-in.Mar 2 2020, 12:22 PM

Will rework the commit message and merge with other related changes.