Differential D27775

IMAP: don't block when displaying the Subscription dialog
ClosedPublic
Actions

Authored by dvratil on Mar 2 2020, 8:26 AM.

Details

Reviewers
winterz
Group Reviewers
KDE PIM
Commits
R44:2b68edaf61c0: IMAP: don't block when displaying the Subscription dialog
Summary

The configureSubscription() slot is invoked via DBus, so using QDialog::exec
to display the dialog may cause the DBus call to time out, leading to a
suspicous warning printed by KMail ("invalid reply").

Diff Detail

Repository
R44 KDE PIM Runtime
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23132
Build 23150: arc lint + arc unit
dvratil created this revision.Mar 2 2020, 8:26 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 2 2020, 8:26 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Mar 2 2020, 8:26 AM
dvratil updated this revision to Diff 76749.Mar 2 2020, 8:27 AM
  • Remove unused include
winterz accepted this revision.Mar 2 2020, 6:33 PM
This revision is now accepted and ready to land.Mar 2 2020, 6:33 PM
Closed by commit R44:2b68edaf61c0: IMAP: don't block when displaying the Subscription dialog (authored by dvratil). · Explain WhyMar 2 2020, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76749

View Options

resources/imap/imapresourcebase.h

Loading...
View Options

resources/imap/imapresourcebase.cpp

Loading...