Differential D27770

HiDPI improvement of left panel
AbandonedPublic
Actions

Authored by guoyunhe on Mar 1 2020, 8:38 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23136
Build 23154: arc lint + arc unit
guoyunhe created this revision.Mar 1 2020, 8:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 1 2020, 8:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Mar 1 2020, 8:38 PM
guoyunhe edited the summary of this revision. (Show Details)Mar 1 2020, 8:39 PM
guoyunhe added a reviewer: Plasma.
davidedmundson requested changes to this revision.Mar 2 2020, 9:31 AM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
applets/kimpanel/backend/ibus/emojier/emojier.cpp
83

this is broken

This revision now requires changes to proceed.Mar 2 2020, 9:31 AM
guoyunhe marked an inline comment as done.Mar 2 2020, 10:35 AM
guoyunhe added inline comments.
applets/kimpanel/backend/ibus/emojier/emojier.cpp
83

Reverted

davidedmundson added a comment.Mar 2 2020, 11:48 AM

Is that diff up to date?

Phab only shows me a QRect changing to a QRectF

guoyunhe abandoned this revision.Mar 2 2020, 2:23 PM
guoyunhe marked an inline comment as done.

I think there can be better solution. Use Breeze icons in the left panel instead of rendering the emoji.

Reference design in Telegram Desktop:

In WhatsApp:

Revision Contents
Changeset List

Diff 76758

View Options

applets/kimpanel/backend/ibus/emojier/emojier.cpp

Loading...