Differential D27741

KCodecs: Convert license statements to SPDX expressions
ClosedPublic
Actions

Authored by cordlandwehr on Feb 29 2020, 5:13 PM.

Details

Reviewers

krop

Maniphest Tasks

T11550: Add SPDX License markers

Commits

R270:25365771652b: KCodecs: Convert license statements to SPDX expressions

Summary

Convert license statements to SPDX expressions and add
license files as required by REUSE specification. Note that some
missing copyright holders were recovered from kdelibs history (see
respective commit)

Diff Detail

Repository

R270 KCodecs

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cordlandwehr created this revision.Feb 29 2020, 5:13 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 29 2020, 5:13 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

cordlandwehr requested review of this revision.Feb 29 2020, 5:13 PM

Harbormaster completed remote builds in B23094: Diff 76689.Feb 29 2020, 5:13 PM

cordlandwehr added a task: T11550: Add SPDX License markers.Feb 29 2020, 5:13 PM

cordlandwehr mentioned this in T11550: Add SPDX License markers.

cordlandwehr retitled this revision from Convert license statements to SPDX expressions to KCodecs: Convert license statements to SPDX expressions.Feb 29 2020, 5:36 PM

krop added a subscriber: krop.Mar 21 2020, 8:58 PM

krop added inline comments.

src/probers/tables/Big5Freq.tab
3–5	You added "Netscape Communications Corporation" on other files but not this one. (IMO, you shouldn't, Netscape is explicitly mentioned only in src/probers/nsSJISProber.h)

cordlandwehr marked an inline comment as done.Mar 22 2020, 12:20 PM

cordlandwehr added inline comments.

src/probers/tables/Big5Freq.tab
3–5	I checked in commit d761a5c62336b6d35e961a3388e65e187bea69c3 in the kdelibs repository and for the other files recovered the original copyright holder names that unfortunately were lost during the license change. yet for this file, even in the original file no copyright holder is named explicitly, only copyright for "Initial Developer" is named without specifying the initial developer. For the other files the "Initial Developer" explicitly is set to "Netscape Communications Corporation".

krop accepted this revision.Mar 23 2020, 9:16 AM

This revision is now accepted and ready to land.Mar 23 2020, 9:16 AM

Closed by commit R270:25365771652b: KCodecs: Convert license statements to SPDX expressions (authored by cordlandwehr). · Explain WhyMar 28 2020, 3:49 PM

This revision was automatically updated to reflect the committed changes.

cordlandwehr marked an inline comment as done.

Revision Contents
Changeset List

		Path
A	M	LICENSES/BSD-3-Clause.txt (26 lines)
A	M	LICENSES/GPL-2.0-or-later.txt (319 lines)
A	M	LICENSES/LGPL-2.0-only.txt (446 lines)
A	M	LICENSES/LGPL-2.0-or-later.txt (446 lines)
A	M	LICENSES/LGPL-2.1-or-later.txt (468 lines)
A	M	LICENSES/MIT.txt (19 lines)
A	M	LICENSES/MPL-1.1.txt (422 lines)
M		autotests/base64benchmark.cpp (17 lines)
M		autotests/codectest.h (17 lines)
M		autotests/codectest.cpp (19 lines)
M		autotests/kcharsetstest.h (19 lines)
M		autotests/kcharsetstest.cpp (19 lines)
M		autotests/kcodecstest.h (16 lines)
M		autotests/kcodecstest.cpp (16 lines)
M		autotests/kemailaddresstest.h (19 lines)
M		autotests/kemailaddresstest.cpp (23 lines)
M		autotests/kencodingprobertest.h (19 lines)
M		autotests/kencodingprobertest.cpp (19 lines)
M		autotests/rfc2047test.h (16 lines)
M		autotests/rfc2047test.cpp (16 lines)
M		cmake/rules_PyKF5.py (27 lines)
M		src/kcharsets.h (22 lines)
M		src/kcharsets.cpp (27 lines)
M		src/kcodecs.h (23 lines)
M		src/kcodecs.cpp (41 lines)
M		src/kcodecs_p.h (15 lines)
M		src/kcodecsbase64.h (19 lines)
M		src/kcodecsbase64.cpp (19 lines)
M		src/kcodecsidentity.h (19 lines)
M		src/kcodecsidentity.cpp (19 lines)
M		src/kcodecsqp.h (19 lines)
M		src/kcodecsqp.cpp (19 lines)
M		src/kcodecsuuencode.h (19 lines)
M		src/kcodecsuuencode.cpp (19 lines)
M		src/kemailaddress.h (19 lines)
M		src/kemailaddress.cpp (19 lines)
M		src/kencodingprober.h (18 lines)
M		src/kencodingprober.cpp (18 lines)
M		src/kentities.gperf (27 lines)
M		src/probers/CharDistribution.h (26 lines)
M		src/probers/CharDistribution.cpp (26 lines)
M		src/probers/ChineseGroupProber.h (24 lines)
M		src/probers/ChineseGroupProber.cpp (24 lines)
M		src/probers/JapaneseGroupProber.h (24 lines)
M		src/probers/JapaneseGroupProber.cpp (24 lines)
M		src/probers/JpCntx.h (24 lines)
M		src/probers/JpCntx.cpp (24 lines)
M		src/probers/LangBulgarianModel.cpp (24 lines)
M		src/probers/LangCyrillicModel.cpp (24 lines)
M		src/probers/LangGreekModel.cpp (24 lines)
M		src/probers/LangHebrewModel.cpp (24 lines)
M		src/probers/LangHungarianModel.cpp (24 lines)
M		src/probers/LangThaiModel.cpp (24 lines)
M		src/probers/UnicodeGroupProber.h (24 lines)
M		src/probers/UnicodeGroupProber.cpp (24 lines)
M		src/probers/nsBig5Prober.h (24 lines)
M		src/probers/nsBig5Prober.cpp (24 lines)
M		src/probers/nsCharSetProber.h (24 lines)
M		src/probers/nsCharSetProber.cpp (24 lines)
M		src/probers/nsCodingStateMachine.h (24 lines)
M		src/probers/nsEUCJPProber.h (24 lines)
M		src/probers/nsEUCJPProber.cpp (24 lines)
M		src/probers/nsEUCKRProber.h (24 lines)
M		src/probers/nsEUCKRProber.cpp (24 lines)
M		src/probers/nsEscCharsetProber.h (24 lines)
M		src/probers/nsEscCharsetProber.cpp (24 lines)
M		src/probers/nsEscSM.cpp (24 lines)
M		src/probers/nsGB2312Prober.h (24 lines)
M		src/probers/nsGB2312Prober.cpp (24 lines)
M		src/probers/nsHebrewProber.h (24 lines)
M		src/probers/nsHebrewProber.cpp (24 lines)
M		src/probers/nsLatin1Prober.h (24 lines)
M		src/probers/nsLatin1Prober.cpp (24 lines)
M		src/probers/nsMBCSGroupProber.h (24 lines)
M		src/probers/nsMBCSGroupProber.cpp (24 lines)
M		src/probers/nsMBCSSM.cpp (24 lines)
M		src/probers/nsPkgInt.h (24 lines)
M		src/probers/nsSBCSGroupProber.h (44 lines)
M		src/probers/nsSBCSGroupProber.cpp (24 lines)
M		src/probers/nsSBCharSetProber.h (24 lines)
M		src/probers/nsSBCharSetProber.cpp (24 lines)
M		src/probers/nsSJISProber.h (42 lines)
M		src/probers/nsSJISProber.cpp (24 lines)
M		src/probers/nsUniversalDetector.h (25 lines)
M		src/probers/nsUniversalDetector.cpp (25 lines)
M		src/probers/tables/Big5Freq.tab (32 lines)
M		src/probers/tables/EUCKRFreq.tab (32 lines)
M		src/probers/tables/GB2312Freq.tab (28 lines)
M		src/probers/tables/JISFreq.tab (34 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76689	cc30eb1		Feb 29 2020, 5:13 PM	★	★
Diff 2	78733	8351b2a	R270:25365771652b6be19cc5888cb50ff1f35a8a69bf	Mar 28 2020, 3:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2ddfc20fac6d	06340cf41287	485b4ff4d86b	Andreas Cord-Landwehr	Add license files are required by REUSE specification	Feb 29 2020, 1:41 PM
485b4ff4d86b	9c3ebd463951	cc30eb197a46	Andreas Cord-Landwehr	Convert license statements to SPDX expressions (Show More…)	Feb 29 2020, 1:41 PM

KCodecs: Convert license statements to SPDX expressionsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 78733

LICENSES/BSD-3-Clause.txt

LICENSES/GPL-2.0-or-later.txt

LICENSES/LGPL-2.0-only.txt

LICENSES/LGPL-2.0-or-later.txt

LICENSES/LGPL-2.1-or-later.txt

LICENSES/MIT.txt

LICENSES/MPL-1.1.txt

autotests/base64benchmark.cpp

autotests/codectest.h

autotests/codectest.cpp

autotests/kcharsetstest.h

autotests/kcharsetstest.cpp

autotests/kcodecstest.h

autotests/kcodecstest.cpp

autotests/kemailaddresstest.h

autotests/kemailaddresstest.cpp

autotests/kencodingprobertest.h

autotests/kencodingprobertest.cpp

autotests/rfc2047test.h

autotests/rfc2047test.cpp

cmake/rules_PyKF5.py

src/kcharsets.h

src/kcharsets.cpp

src/kcodecs.h

src/kcodecs.cpp

src/kcodecs_p.h

src/kcodecsbase64.h

src/kcodecsbase64.cpp

src/kcodecsidentity.h

src/kcodecsidentity.cpp

src/kcodecsqp.h

src/kcodecsqp.cpp

src/kcodecsuuencode.h

src/kcodecsuuencode.cpp

src/kemailaddress.h

src/kemailaddress.cpp

src/kencodingprober.h

src/kencodingprober.cpp

src/kentities.gperf

src/probers/CharDistribution.h

src/probers/CharDistribution.cpp

src/probers/ChineseGroupProber.h

src/probers/ChineseGroupProber.cpp

src/probers/JapaneseGroupProber.h

src/probers/JapaneseGroupProber.cpp

src/probers/JpCntx.h

src/probers/JpCntx.cpp

src/probers/LangBulgarianModel.cpp

src/probers/LangCyrillicModel.cpp

src/probers/LangGreekModel.cpp

src/probers/LangHebrewModel.cpp

src/probers/LangHungarianModel.cpp

src/probers/LangThaiModel.cpp

src/probers/UnicodeGroupProber.h

src/probers/UnicodeGroupProber.cpp

src/probers/nsBig5Prober.h

src/probers/nsBig5Prober.cpp

src/probers/nsCharSetProber.h

src/probers/nsCharSetProber.cpp

src/probers/nsCodingStateMachine.h

src/probers/nsEUCJPProber.h

src/probers/nsEUCJPProber.cpp

src/probers/nsEUCKRProber.h

src/probers/nsEUCKRProber.cpp

src/probers/nsEscCharsetProber.h

src/probers/nsEscCharsetProber.cpp

src/probers/nsEscSM.cpp

src/probers/nsGB2312Prober.h

src/probers/nsGB2312Prober.cpp

src/probers/nsHebrewProber.h

src/probers/nsHebrewProber.cpp

src/probers/nsLatin1Prober.h

src/probers/nsLatin1Prober.cpp

src/probers/nsMBCSGroupProber.h

src/probers/nsMBCSGroupProber.cpp

KCodecs: Convert license statements to SPDX expressions
ClosedPublic
Actions

Revision Contents
Changeset List