Differential D27632

Implement UString operator= to make gcc happy
ClosedPublic
Actions

Authored by aacid on Feb 24 2020, 10:46 PM.

Details

Reviewers
porten
Commits
R314:e637e721e40e: Implement UString operator= to make gcc happy
Summary

otherwise complains that there's a copy constructor but not an
assignment operator

Diff Detail

Repository
R314 KJs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Feb 24 2020, 10:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 24 2020, 10:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Feb 24 2020, 10:46 PM
aacid added a subscriber: porten.Feb 24 2020, 10:46 PM
porten added a comment.Feb 24 2020, 11:07 PM

On first sight I don't get how the class' memory management works these days. Before commenting on the patch I have to refresh my knowledge.

porten accepted this revision.Apr 11 2020, 9:22 PM

I now see that the member is kept as a RefPtr. Unlike the previously used raw pointer I now understand why the the assignment operator can be implemented that simple.

For completness: the gcc switch that triggers the warning is -Wdeprecated-copy

This revision is now accepted and ready to land.Apr 11 2020, 9:22 PM
Closed by commit R314:e637e721e40e: Implement UString operator= to make gcc happy (authored by aacid). · Explain WhyApr 12 2020, 10:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kjs/ustring.h (1 line)

Diff 79911

View Options

src/kjs/ustring.h

Loading...