- screen identification osd now uses plasma styling, it's workspace thing
- simplified the code
- made it high-dpi compatible
Details
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R104:535bf03d03a5: style and high dpi fixes for screen identification OSD
tested on various displays, works fine, also themed now by Plasma
Diff Detail
Diff Detail
- Repository
- R104 KScreen
- Branch
- sebas/screenid
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
It would, and I played with it, but:
This would need an ARGB window and also fallbacks to opaque components, at that point, we'd be duplicating much of the code in Plasma::Dialog (from plasmaquick). Since this code is hopefully going away for a yet-to-be-designed replacement mechanism, it isn't worth the hassle
I'm not using the existing OSD since it doesn't allow us to place anything on a specific screen (kwin's job to decide), so it's pretty useless here. Extending that to allow what we need would mean going through KWindowSystem as well. I do think it's the proper solution in the end, and it would then also work on Wayland, but it's way too late for 5.8 now.
This patch strikes I think a reasonable balance to make it a bit less ugly for 5.8 at least.
Comment Actions
Lgtm. Some nitpicks below.
For some reason the right border is smaller than the other ones (has been the case without this patch already), so maybe QML Rectangle border leaks outside the window or so :/
| kcm/qml/OutputIdentifier.qml | ||
|---|---|---|
| 37 ↗ | (On Diff #6690) | width: childrenRect.width + 2 * childrenRect.x to reduce magic numbers |
| 46 ↗ | (On Diff #6690) | Why not just a Label since you're not using the one thing that makes Heading special (the font size with "level" magic) |
| 47–49 ↗ | (On Diff #6690) | Remove, you're not setting a top anchor and you set Y already |