Differential D27598

Apply type_filters on normalized type as per comment
ClosedPublic
Actions

Authored by broulik on Feb 23 2020, 1:20 PM.

Details

Reviewers
vkrause
Commits
R1003:d36a42280831: Apply type_filters on normalized type as per comment
Summary

The comment said "filter functions applied to objects of the corresponding (already normalized) type" but it didn't.
Probably went unnoticed as we don't actually normalize any of the types that have a specialized filter right now.

Test Plan
  • Added a FoodEstablishment filter which is executed now. Previously it would try to run a Restaurant filter.

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 23 2020, 1:20 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 23 2020, 1:20 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
broulik requested review of this revision.Feb 23 2020, 1:20 PM
vkrause accepted this revision.Feb 23 2020, 1:59 PM
This revision is now accepted and ready to land.Feb 23 2020, 1:59 PM
Closed by commit R1003:d36a42280831: Apply type_filters on normalized type as per comment (authored by broulik). · Explain WhyFeb 24 2020, 8:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/jsonldimportfilter.cpp (5 lines)

Diff 76260

View Options

src/jsonldimportfilter.cpp

Loading...