Fix simpleWrite test in kwaylandbackendtest
ClosedPublic

Authored by dvratil on Feb 21 2020, 9:21 AM.

Details

Summary

The test still fails on removeOutput test, but that's fixed by
D27536.

Test Plan

simpleWrite test passes

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Feb 21 2020, 9:21 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2020, 9:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dvratil requested review of this revision.Feb 21 2020, 9:21 AM
romangg accepted this revision.Feb 21 2020, 12:02 PM
romangg added a subscriber: romangg.

Please follow commit message guideline.

This revision is now accepted and ready to land.Feb 21 2020, 12:02 PM
This revision was automatically updated to reflect the committed changes.

Thanks, but the commit message in wrong as the type must be test since this is a fix to an autotest. And the scope autotest does not exist. See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md

Also the header is not very expressive. A "fix" can be everything and the kitchen sink.

I will revert the commit and if you would like to recommit I would recommend the header:

test: query correct output