Fix simpleWrite test in kwaylandbackendtest
ClosedPublic
Actions

Authored by dvratil on Feb 21 2020, 9:21 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

The test still fails on removeOutput test, but that's fixed by
D27536.

Test Plan

simpleWrite test passes

Repository

R110 KScreen Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

dvratil requested review of this revision.Feb 21 2020, 9:21 AM

Please follow commit message guideline.

This revision is now accepted and ready to land.Feb 21 2020, 12:02 PM

This revision was automatically updated to reflect the committed changes.

Thanks, but the commit message in wrong as the type must be test since this is a fix to an autotest. And the scope autotest does not exist. See https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md

Also the header is not very expressive. A "fix" can be everything and the kitchen sink.

I will revert the commit and if you would like to recommit I would recommend the header:

test: query correct output

			Path	Packages
M			autotests/testkwaylandbackend.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	76083	274d94e		Feb 21 2020, 9:21 AM	★	★
Diff 2	76104	d5304fd	R110:2fcd093919b88ebb619658a739f7f56e9134a82a	Feb 21 2020, 12:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
dc99e2ff268f	5f25998c3968	274d94ed6453	Daniel Vrátil	Fix simpleWrite test in kwaylandbackendtest (Show More…)	Feb 21 2020, 9:20 AM