Differential D27488

[plastik] Disable problematic text hints
ClosedPublic
Actions

Authored by davidedmundson on Feb 18 2020, 11:32 PM.

Details

Reviewers

zzag

Group Reviewers

KWin

Commits

R108:39798bffb139: [plastik] Disable problematic text hints

Summary

Use of "style: Text.Raised" combined with UTF-8 emoji characters
currently crashes deep in font rendering code.

A report has been submitted upstream:
https://bugreports.qt.io/browse/QTBUG-82311

Given this crash is surprisingly common, this patch removes the text
shadow. I normally would be against it, but this was a subtle effect
anyway and frankly just made things look blurry. I doubt it'll be missed.

BUG: 417699
BUG: 413179

Test Plan

Made unit test for the crash in qmlscene
Fixed the issue there

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Feb 18 2020, 11:32 PM

Restricted Application added a project: KWin. · View Herald TranscriptFeb 18 2020, 11:32 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Feb 18 2020, 11:32 PM

Harbormaster completed remote builds in B22647: Diff 75948.Feb 18 2020, 11:32 PM

zzag accepted this revision.Feb 19 2020, 8:01 AM

This revision is now accepted and ready to land.Feb 19 2020, 8:01 AM

Closed by commit R108:39798bffb139: [plastik] Disable problematic text hints (authored by davidedmundson). · Explain WhyFeb 19 2020, 8:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/kdecorations/aurorae/themes/plastik/package/contents/config/main.xml (3 lines)
M			plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/config.ui (11 lines)
M			plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/main.qml (4 lines)