Differential D27448

[kcms/feedback] Improve default kcmshell window size
ClosedPublic
Actions

Authored by ngraham on Feb 17 2020, 12:09 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
VDG
Commits
R120:285155fad1f3: [kcms/feedback] Improve default kcmshell window size
Summary

BUG: 417747
FIXED-IN: 5.18.1

Test Plan

Better default size when showing the most info:

However window is too now big when showing the least amount of info:

...But that seems kind of unavoidable unless we want to dynamically resize the window,
which people seem to hate.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 17 2020, 12:09 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2020, 12:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 17 2020, 12:09 AM
apol accepted this revision.Feb 17 2020, 12:15 AM
apol added a subscriber: apol.

Okay.

I wonder if we should be launching systemsettings rather than kcmshell...

This revision is now accepted and ready to land.Feb 17 2020, 12:15 AM
ngraham added a comment.Feb 17 2020, 12:33 AM
In D27448#612644, @apol wrote:

Okay.

I wonder if we should be launching systemsettings rather than kcmshell...

Please place relevant thoughts and opinions in https://bugs.kde.org/show_bug.cgi?id=402790. :) It would certainly eliminate this whole class of bug.

Closed by commit R120:285155fad1f3: [kcms/feedback] Improve default kcmshell window size (authored by ngraham). · Explain WhyFeb 17 2020, 12:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75807

View Options

kcms/feedback/package/contents/ui/main.qml

Loading...