Differential D27429

ThreadWeaver: Convert license headers to SPDX expressions
ClosedPublic
Actions

Authored by cordlandwehr on Feb 16 2020, 8:24 AM.

Details

Reviewers
krop
Maniphest Tasks
T11550: Add SPDX License markers
Commits
R279:9a3095522026: ThreadWeaver: Convert license headers to SPDX expressions
Summary

Add license files are required by REUSE and add license
files as reuqired by REUSE.

Please note the following points:

  • all links to dead webpages were removed from license statements
  • I do not think that the ID markers are still needed, which are contained in several license headers (@mirko: are they still needed?)
  • In both src/examples/ItemdDelegate.cpp/.h there is a license clarification that this file may be linked with any version of Qt. I do not see that this license clarification is needed, because that automatically comes with the LGPL. (@all: what is your opinion?)

Diff Detail

Repository
R279 ThreadWeaver
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr created this revision.Feb 16 2020, 8:24 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 16 2020, 8:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cordlandwehr requested review of this revision.Feb 16 2020, 8:24 AM
krop accepted this revision.Mar 21 2020, 8:21 PM
krop added a subscriber: krop.

LGTM

examples/HelloInternet/main.cpp
1 ↗(On Diff #75756)

I don't see what changed here. looks unrelated to this PR

This revision is now accepted and ready to land.Mar 21 2020, 8:21 PM
cordlandwehr updated this revision to Diff 78215.Mar 22 2020, 11:58 AM

Revert change

krop accepted this revision.Mar 22 2020, 11:59 AM
Closed by commit R279:9a3095522026: ThreadWeaver: Convert license headers to SPDX expressions (authored by cordlandwehr). · Explain WhyMar 22 2020, 12:00 PM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 118 files. Files without inline comments have been collapsed. Expand All Files

Showing Only Differences

This revision modifies 118 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 78216