Add missing cursors for Chromium-based apps
ClosedPublic

Authored by guilhermesilva on Feb 15 2020, 3:35 PM.

Details

Summary

The Cursor Specification doesn't even mention these two, but Chromium-based apps search for them using a different name than ours, so it wouldn't hurt to symlink them.

Test Plan

This can be tested on any webpage using either cursor: grab or cursor: grabbing CSS rule. But here's a page where you can easily test them:

http://elektronotdienst-nuernberg.de/bugs/cursor.html

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
guilhermesilva created this revision.Feb 15 2020, 3:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2020, 3:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guilhermesilva requested review of this revision.Feb 15 2020, 3:35 PM
guilhermesilva edited the summary of this revision. (Show Details)Feb 15 2020, 4:41 PM
ngraham accepted this revision.Feb 15 2020, 6:07 PM
ngraham added reviewers: Breeze, broulik.
ngraham added a subscriber: ngraham.

Thanks for the patch! Hope the process wasn't too tough to get through for the first time.

LGTM! @broulik, does this look good to you too?

This revision is now accepted and ready to land.Feb 15 2020, 6:08 PM

It wouldn't call it tough, but it wasn't that easy either... Hahah.

Thanks for pointing me to the right direction too!

broulik accepted this revision.Feb 17 2020, 3:22 PM

Cool, thanks! I was totally oblivious of the fact the page had three columns :)

This can go into 5.18 I'd say

This revision was automatically updated to reflect the committed changes.

Landed for Plasma 5.18.1! Very nice patch. May it be the first of many! :)

Absolutely! Thank you very much.