Differential D274

Fix SearchCollection from AkonadiFakeStorage
ClosedPublic
Actions

Authored by franckarrecot on Aug 26 2015, 4:54 PM.

Details

Reviewers
bensi
ervin
remibenoit
Commits
R4:161b00186455: Fix SearchCollection from AkonadiFakeStorage
Summary

It wasn't recreating all the ancestors hierarchy as SearchCollection did.
added the unit test with it.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
franckarrecot updated this revision to Diff 617.Aug 26 2015, 4:54 PM
franckarrecot retitled this revision from to Fix SearchCollection from AkonadiFakeStorage.
franckarrecot updated this object.
franckarrecot edited the test plan for this revision. (Show Details)
franckarrecot added reviewers: ervin, bensi, remibenoit.Aug 26 2015, 4:56 PM

I needed this one to keep porting.

franckarrecot added a comment.Aug 26 2015, 4:57 PM

I needed this one to keep porting.

ervin requested changes to this revision.Aug 26 2015, 5:51 PM
ervin edited edge metadata.
ervin added inline comments.
tests/testlib/akonadifakestorage.cpp
411

Please fix the indentation here.

tests/testlib/akonadistoragetestbase.h
93

Please rename: shouldFindCollectionsByNameIncludingTheirAncestors()

This revision now requires changes to proceed.Aug 26 2015, 5:51 PM
franckarrecot updated this revision to Diff 619.Aug 26 2015, 8:36 PM
franckarrecot edited edge metadata.

fix indent and name

ervin accepted this revision.Aug 26 2015, 8:39 PM
ervin edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2015, 8:39 PM
franckarrecot updated this revision to Diff 638.Aug 29 2015, 11:12 AM
franckarrecot edited edge metadata.

reviewer: ervin, bensin, remibenoit

Closed by commit R4:161b00186455: Fix SearchCollection from AkonadiFakeStorage (authored by franckarrecot). · Explain WhySep 7 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 785

View Options

tests/testlib/akonadifakestorage.cpp

Loading...
View Options

tests/testlib/akonadistoragetestbase.h

Loading...
View Options

tests/testlib/akonadistoragetestbase.cpp

Loading...