Expand the row when selected and show more information
ClosedPublic

Authored by ervin on Sep 10 2016, 4:34 PM.

Details

Summary

Added some more information to display in the item delegate of the
central view. Now we display the due date right aligned if available and
also we show the first few lines of the artifact text when the item is
the current item (requiring a higher row).

It led to a massive refactoring of the delegate.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 6622.Sep 10 2016, 4:34 PM
ervin retitled this revision from to Expand the row when selected and show more information.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot, dfaure.
franckarrecot accepted this revision.Sep 12 2016, 9:16 PM
franckarrecot edited edge metadata.
This revision is now accepted and ready to land.Sep 12 2016, 9:16 PM
dfaure added inline comments.Sep 13 2016, 9:28 AM
src/widgets/itemdelegate.cpp
104

Typo? Should this be dueDate.date() < QDate::currentDate()?

153

This rect is only used in one if() below, move it there? It's weird to see the division by SELECTED_FACTOR happening when isCurrent is false (in which case it doesn't make sense).

The QString extraText can be moved too.

ervin marked 2 inline comments as done.Nov 22 2016, 6:00 PM
ervin updated this revision to Diff 8418.Nov 22 2016, 6:09 PM
ervin edited edge metadata.

Addressing dfaure's comments

dfaure accepted this revision.Nov 23 2016, 7:56 AM
dfaure edited edge metadata.
This revision was automatically updated to reflect the committed changes.