Differential D27369

Fix loading of lyrics from lyrics.wikia.com
ClosedPublic
Actions

Authored by pgomes on Feb 13 2020, 2:05 PM.

Details

Reviewers
amarok-devel
heikobecker
Group Reviewers
Amarok
Commits
R181:7f966e2a46c9: Fix loading of lyrics from lyrics.wikia.com
Summary

Fix error where Amarok failed to load lyrics from lyrics.wikia.com because the domain was being redirected to lyrics.fandom.com.

KDE Bugtracking System: https://bugs.kde.org/show_bug.cgi?id=417259

The fix does two things:

  • update the base API Url to the redirected domain lyrics.fandom.com, thus skipping the redirection
  • makes LyricsManager react to possible future redirections

Diff Detail

Repository
R181 Amarok
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pgomes created this revision.Feb 13 2020, 2:05 PM
pgomes created this object with edit policy "Administrators".
Restricted Application removed a project: Amarok. · View Herald TranscriptFeb 13 2020, 2:05 PM
Restricted Application added subscribers: amarok-devel, Amarok. · View Herald Transcript
pgomes requested review of this revision.Feb 13 2020, 2:05 PM
pgomes edited reviewers, added: Amarok, amarok-devel; removed: schweingruber.Feb 13 2020, 2:46 PM
heikobecker accepted this revision.Feb 21 2020, 4:41 PM
This revision is now accepted and ready to land.Feb 21 2020, 4:41 PM
pgomes added a comment.Feb 24 2020, 2:32 PM

@heikobecker thank you for the reviews. I don't have commit privilege. Please push it.

Closed by commit R181:7f966e2a46c9: Fix loading of lyrics from lyrics.wikia.com (authored by pgomes, committed by heikobecker). · Explain WhyFeb 25 2020, 10:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 76425

View Options

src/lyrics/LyricsManager.h

Loading...
View Options

src/lyrics/LyricsManager.cpp

Loading...