Don't constrain width of Text field on translated text
ClosedPublic
Actions

Authored by davidedmundson on Sep 9 2016, 2:16 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

This caused it to be cropped on some translations.

This patch only sets the minimum size to force it to line up with the form layout,
but still allow the text to be larger if needed.

Also tidy up other use of directly setting width/anchors in a layout.

BUG:368487

Test Plan

Checked English layout matched up
Changed text to "asdfasdfadsfasdfljasdfjadlf" and checked that still fit

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Don't constrain width of Text field on translated text.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart added a reviewer: mart.

This revision is now accepted and ready to land.Sep 13 2016, 4:06 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			wallpapers/image/imagepackage/contents/ui/config.qml (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6603	64a3a1c		Sep 9 2016, 2:16 PM	★	★
Diff 2	6702	f7469f6	rPLASMAWORKSPACEf78fbac8ff98790ebbb864f00f6f69b131d527b5	Sep 13 2016, 4:35 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
127e42b2b820	78db758b4dee	64a3a1cd4167	David Edmundson	Don't constrain width of Text field on translated text (Show More…)	Sep 9 2016, 2:14 PM