Differential D27242

Require kdecoration >= 5.18.0
ClosedPublic
Actions

Authored by heikobecker on Feb 8 2020, 12:38 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:6d8f3732c1fb: Require kdecoration >= 5.18.0
Summary

To successfully build kwin needs 13e6459a3baeebe6a7b594efd995b88f6dd7524e
in kdecoration. Otherwise it fails with: "previewclient.h:93:11: error:
'QSize KDecoration2::Preview::PreviewClient::size() const' marked
'override', but does not override QSize size() const override;"
So this is not a new requirement but just an update to the build system
to reflect the actual requirements.

Test Plan

Builds fine with the newly required version

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Feb 8 2020, 12:38 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 8 2020, 12:38 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
heikobecker requested review of this revision.Feb 8 2020, 12:38 PM
zzag accepted this revision.Feb 8 2020, 12:53 PM
This revision is now accepted and ready to land.Feb 8 2020, 12:53 PM
Closed by commit R108:6d8f3732c1fb: Require kdecoration >= 5.18.0 (authored by heikobecker). · Explain WhyFeb 8 2020, 1:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 75249

View Options

CMakeLists.txt

Loading...