Differential D27165

[krdb] Hardcode Breeze default in kde4 migration
ClosedPublic
Actions

Authored by broulik on Feb 5 2020, 10:52 AM.

Details

Reviewers
crossi
Group Reviewers
Plasma
Commits
R119:0e4eaf013fb5: [krdb] Hardcode Breeze default in kde4 migration
Summary

With the KConfigXT changes, the default isn't written anymore, so it wouldn't sync the default Breeze scheme anymore.

Test Plan
  • Changed to a different color scheme and back and my LibreOffice kde4 is fine

I think 5.18?

Either we port this to kconfigxt since it is clearly broken all over the place now with the config values not being present anymore, or phase out this kde4 stuff altogether for 5.19

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 5 2020, 10:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 5 2020, 10:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 5 2020, 10:52 AM
crossi accepted this revision.Feb 5 2020, 1:36 PM
This revision is now accepted and ready to land.Feb 5 2020, 1:36 PM
Closed by commit R119:0e4eaf013fb5: [krdb] Hardcode Breeze default in kde4 migration (authored by broulik). · Explain WhyFeb 5 2020, 1:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/krdb/krdb.cpp (7 lines)

Diff 75049

View Options

kcms/krdb/krdb.cpp

Loading...