[Notifications] Don't dodge notification popups
ClosedPublic

Authored by broulik on Mon, Feb 3, 4:41 PM.

Details

Summary

This wasn't an issue before as notification popups could never have focus.
However, now with quick reply, they can, leading to funky results and gaps when a notification appears while answering another one.

Test Plan

5.18 please

  • Ran sleep 3; notify-send foo bar and then spawned a quick reply notification and clicked the text field.

Previously I Would end up with weird situations like this, where the new notification popup would try to avoid the focussed popup, which then would also shift downwards to avoid the other popup, etc


With this patch they are always placed correctly.

They still avoid systray popups and the calendar as before

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mon, Feb 3, 4:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Feb 3, 4:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mon, Feb 3, 4:41 PM
broulik updated this revision to Diff 74941.Mon, Feb 3, 4:46 PM
  • Remove check for self since we know that this is always a popup
ngraham accepted this revision.Mon, Feb 3, 4:55 PM
ngraham added a subscriber: ngraham.

Clever!

This revision is now accepted and ready to land.Mon, Feb 3, 4:55 PM
This revision was automatically updated to reflect the committed changes.