Differential D2702

flake: Include <cmath> rather than <math.h>
ClosedPublic
Actions

Authored by heikobecker on Sep 7 2016, 10:18 PM.

Details

Reviewers
Calligra-Devel-list
kossebau
Commits
R8:08b2bacdeeda: flake: Include <cmath> rather than <math.h>
Summary

With the latter I get an build error with gcc-5: "KoSnapStrategy.cpp:78:14:
error: '__builtin_isfinite' is not a member of 'std'".

Test Plan

Builds fine

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker updated this revision to Diff 6525.Sep 7 2016, 10:18 PM
heikobecker retitled this revision from to flake: Include <cmath> rather than <math.h>.
heikobecker updated this object.
heikobecker edited the test plan for this revision. (Show Details)
heikobecker added a reviewer: Calligra-Devel-list.
heikobecker added a project: Calligra: 3.0.
Restricted Application added a project: KEXI. · View Herald TranscriptSep 7 2016, 10:18 PM
kossebau accepted this revision.Sep 19 2016, 3:32 PM
kossebau added a reviewer: kossebau.
kossebau added a subscriber: kossebau.
kossebau added inline comments.
libs/flake/KoSnapStrategy.cpp
31–32

Please also remove this no longer needed #define, given plain isfinite is no longer used.

This revision is now accepted and ready to land.Sep 19 2016, 3:32 PM
Closed by commit R8:08b2bacdeeda: flake: Include <cmath> rather than <math.h> (authored by heikobecker). · Explain WhySep 19 2016, 7:02 PM
This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Mlibs/flake/KoSnapStrategy.cpp (6 lines)

Diff 6820

View Options

libs/flake/KoSnapStrategy.cpp

Loading...