Differential D26985

[Panel Shadows] Un-constify QWindow parameters
ClosedPublic
Actions

Authored by zzag on Jan 29 2020, 11:54 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R120:bb60002b1340: [Panel Shadows] Un-constify QWindow parameters
Summary

It doesn't make sense to pass const QWindows to PanelShadows because
a KWindowShadow needs a mutable QWindow object.

Test Plan

const_cast in PanelShadows::Private::updateShadow is gone \o/

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jan 29 2020, 11:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 29 2020, 11:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Jan 29 2020, 11:54 AM
apol accepted this revision.Jan 29 2020, 3:13 PM
This revision is now accepted and ready to land.Jan 29 2020, 3:13 PM
Closed by commit R120:bb60002b1340: [Panel Shadows] Un-constify QWindow parameters (authored by zzag). · Explain WhyJan 29 2020, 3:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/panelshadows.cpp (20 lines)
Mshell/panelshadows_p.h (6 lines)

Diff 74585

View Options

shell/panelshadows.cpp

Loading...
View Options

shell/panelshadows_p.h

Loading...