Differential D2696

Add an ErrorHandler to display errors on top of the PageView
ClosedPublic
Actions

Authored by ervin on Sep 7 2016, 3:18 PM.

Details

Reviewers
bensi
dfaure
franckarrecot
Commits
R4:5d6bcb0393b6: Add an ErrorHandler to display errors on top of the PageView

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 6516.Sep 7 2016, 3:18 PM
ervin retitled this revision from to Add an ErrorHandler to display errors on top of the PageView.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: franckarrecot, bensi.
franckarrecot accepted this revision.Sep 10 2016, 9:33 AM
franckarrecot edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2016, 9:33 AM
dfaure added inline comments.Sep 10 2016, 9:44 AM
src/widgets/pageviewerrorhandler.cpp
4

Shouldn't that be you? ;-)

tests/units/widgets/pageviewerrorhandlertest.cpp
93

Can't use QSignalSpy::wait rather than a fixed-time wait?
Making tests run faster is always good (more people run them, then ;)

ervin marked 2 inline comments as done.Sep 10 2016, 4:25 PM
ervin updated this revision to Diff 6618.Sep 10 2016, 4:33 PM
ervin edited edge metadata.

Addressing David's comments

dfaure accepted this revision.Sep 10 2016, 8:15 PM
dfaure edited edge metadata.
Closed by commit R4:5d6bcb0393b6: Add an ErrorHandler to display errors on top of the PageView (authored by ervin). · Explain WhyNov 23 2016, 8:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8429

View Options

src/widgets/CMakeLists.txt

Loading...
View Options

src/widgets/pageviewerrorhandler.h

Loading...
View Options

src/widgets/pageviewerrorhandler.cpp

Loading...
View Options

tests/units/widgets/CMakeLists.txt

Loading...
View Options

tests/units/widgets/pageviewerrorhandlertest.cpp

Loading...