Differential D26958

[Kickoff] Don't enable OpacityMask layer.effect in software mode
ClosedPublic
Actions

Authored by broulik on Jan 28 2020, 10:27 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:7a727fde4cb9: [Kickoff] Don't enable OpacityMask layer.effect in software mode
Summary

It won't render otherwise. The code tried to check but only disabled the outline, not the actual effect.

Test Plan

5.18

  • Ran QT_QUICK_BACKEND=software plasmashell and got my user shown in kickoff. In a square rather than a circle but better than not rendering the avatar at all

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 28 2020, 10:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 28 2020, 10:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 28 2020, 10:27 AM
davidedmundson accepted this revision.Jan 28 2020, 10:29 AM
This revision is now accepted and ready to land.Jan 28 2020, 10:29 AM
Closed by commit R119:7a727fde4cb9: [Kickoff] Don't enable OpacityMask layer.effect in software mode (authored by broulik). · Explain WhyJan 28 2020, 10:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74483

View Options

applets/kickoff/package/contents/ui/Header.qml

Loading...