Differential D2695

Integrate KMessageWidget in PageView to display errors
ClosedPublic
Actions

Authored by ervin on Sep 7 2016, 3:18 PM.

Details

Reviewers
bensi
dfaure
franckarrecot
Commits
R4:9f9d68ebe5e5: Integrate KMessageWidget in PageView to display errors

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 6515.Sep 7 2016, 3:18 PM
ervin retitled this revision from to Integrate KMessageWidget in PageView to display errors.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: franckarrecot, bensi.
franckarrecot accepted this revision.Sep 10 2016, 9:28 AM
franckarrecot edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2016, 9:28 AM
dfaure added inline comments.Sep 10 2016, 9:42 AM
src/widgets/pageview.cpp
124

I wouldn't change focus policy, in dolphin it can be useful to select the text of the error and use Ctrl+C to copy it.

ervin marked an inline comment as done.Sep 10 2016, 4:20 PM
ervin updated this revision to Diff 6617.Sep 10 2016, 4:33 PM
ervin edited edge metadata.

Addressing David's comments

dfaure accepted this revision.Sep 10 2016, 4:40 PM
dfaure edited edge metadata.
Closed by commit R4:9f9d68ebe5e5: Integrate KMessageWidget in PageView to display errors (authored by ervin). · Explain WhyNov 23 2016, 8:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8428

View Options

src/widgets/pageview.h

Loading...
View Options

src/widgets/pageview.cpp

Loading...
View Options

tests/units/widgets/pageviewtest.cpp

Loading...