Differential D26938

Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate
ClosedPublic
Actions

Authored by kossebau on Jan 27 2020, 1:17 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R51:63207813d6d5: Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate
Summary

Allows users of the macro to control whether gcc-specific line
markers/directives are generated or not.

Test Plan

KDevelop's qmakemanager plugin built with gcc and using
ENFORCE_COMPATIBLE_ERROR_AWARE_CODE no longer emits warnings of the kind
"style of line directive is a GCC extension"

Diff Detail

Repository
R51 KDevelop: PG Qt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jan 27 2020, 1:17 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJan 27 2020, 1:17 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 27 2020, 1:17 PM
kossebau added a comment.Jan 27 2020, 1:18 PM

Plan is to do a 2.2.1 release directly after that (also needed to officially get the Qt 5.14 build-fix out), so this is available to kdevelop 5.5

kossebau added a comment.Jan 30 2020, 2:52 PM

Anyone who takes enough interest in kdev-pg-qt to care for review? :)

Otherwise would go with it tomorrow on Friday.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 31 2020, 7:24 PM
Closed by commit R51:63207813d6d5: Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate (authored by kossebau). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MKDevelop-PG-QtConfig.cmake.in (5 lines)

Diff 74814

View Options

KDevelop-PG-QtConfig.cmake.in

Loading...