Fix Windows build (Qt5.14 deprecation)
ClosedPublic

Authored by jjazeix on Jan 26 2020, 12:59 PM.

Details

Reviewers
sitter
Group Reviewers
Plasma
Summary

Fixes https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/

The fix still uses a deprecated method but it's the easier to put in place for now.
A clean fix would be:

QString str;
QTextStream ts(&str);
ts << Qt::hex << "0x" << qSetFieldWidth(8) << Qt::right << i;

and use str.
But as we are inside argument function, it would need a bit of rework.

Diff Detail

Repository
R871 DrKonqi
Lint
Lint Skipped
Unit
Unit Tests Skipped
jjazeix created this revision.Jan 26 2020, 12:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 26 2020, 12:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jjazeix requested review of this revision.Jan 26 2020, 12:59 PM
jjazeix edited the summary of this revision. (Show Details)
sitter accepted this revision.Jan 27 2020, 11:26 AM
sitter added a subscriber: sitter.

LGTM. Not that I understand where the sprintf function disappeared to.

This revision is now accepted and ready to land.Jan 27 2020, 11:26 AM