Warn user when changing selected user about potential data loss
ClosedPublic

Authored by meven on Wed, Jan 22, 4:00 PM.

Details

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Wed, Jan 22, 4:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Jan 22, 4:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Wed, Jan 22, 4:00 PM
meven updated this revision to Diff 74135.Wed, Jan 22, 4:03 PM

Clean patch

ngraham requested changes to this revision.Wed, Jan 22, 6:02 PM
ngraham added inline comments.
src/accountinfo.cpp
108
  1. Needs more whitespace around things
  2. Change string to "Save changes to this user?"
  3. What's this <qt> tag? Why is it needed?
This revision now requires changes to proceed.Wed, Jan 22, 6:02 PM
meven updated this revision to Diff 74159.Wed, Jan 22, 6:23 PM

Remove <qt> tags, more indentation, change confirmation text

meven marked an inline comment as done.Wed, Jan 22, 6:23 PM
meven added inline comments.
src/accountinfo.cpp
108
  1. done
  2. done
  3. no idea was from copy/paste
meven marked 2 inline comments as done.Wed, Jan 22, 6:24 PM
ngraham accepted this revision.Wed, Jan 22, 8:06 PM

Lovely. I could have sworn we had a bug report about this, but I can't find it now. Regardless, nice fix.

This revision is now accepted and ready to land.Wed, Jan 22, 8:06 PM
This revision was automatically updated to reflect the committed changes.