Differential D26835

Drop kdeinit linking
ClosedPublic
Actions

Authored by davidedmundson on Jan 22 2020, 12:03 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:996e84017279: Drop kdeinit linking
Summary

This wasn't used on startup (ksmserver calls KProcess)
Nor for the rules dialog (kwin invokes it with QProcess)

We may as well simplify the code and drop the dependency

See also T12140

Test Plan

Restarted
Opened the rules dialog

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptJan 22 2020, 12:03 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 22 2020, 12:03 PM
zzag accepted this revision.Jan 22 2020, 12:06 PM
This revision is now accepted and ready to land.Jan 22 2020, 12:06 PM
Closed by commit R108:996e84017279: Drop kdeinit linking (authored by davidedmundson). · Explain WhyJan 22 2020, 1:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (48 lines)
Mkcmkwin/kwinrules/CMakeLists.txt (9 lines)
Mkcmkwin/kwinrules/main.cpp (3 lines)
Mmain_x11.cpp (3 lines)

Diff 74109

View Options

CMakeLists.txt

Loading...
View Options

kcmkwin/kwinrules/CMakeLists.txt

Loading...
View Options

kcmkwin/kwinrules/main.cpp

Loading...
View Options

main_x11.cpp

Loading...