Fix download page background color
ClosedPublic

Authored by aureliencouderc on Jan 21 2020, 9:56 AM.

Details

Summary

Dear upstream maintainer,

while updating the artikulate package for Debian, I noticed that the current code doesn’t correctly handle dark themes when displaying the list of downloads.
When using breeze dark for example the name of the items are light grey on a white background.

This simple patch fixes that by not forcing the color and leaving the default background color. With this change the display is correct with both breeze and breeze dark themes.

Test Plan
  • Select breeze (light) application theme
  • Start Artikulate and go to the download page
  • Check that the text of the items to download is readable.
  • Swtich to the breeze dark application theme
  • Check that the text of the items to download is still readable.

Diff Detail

Repository
R72 Artikulate
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 21 2020, 9:56 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
aureliencouderc requested review of this revision.Jan 21 2020, 9:56 AM
aacid added a subscriber: aacid.Jan 28 2020, 11:44 PM

But the use of white there is on purpose, of course it breaks the dark themes, but maybe there's a color from https://api.kde.org/frameworks/kirigami/html/classorg_1_1kde_1_1kirigami_1_1Theme.html that we can use?

Can you try finding one that looks white-ish on breeze but still works on breeze-dark?

Dear Albert,

so if I understand correctly you don’t like the default text / background of breeze for this page.

Please find an updated patch using the viewBackgroundColor.
I hope this matches more what you have in mind.

I’ll attache screenshots for breeze & breeze dark.

Happy hacking !

Aurélien

Update patch following maintainer feedback.

aacid accepted this revision.Jan 30 2020, 10:59 PM

That looks great :)

This revision is now accepted and ready to land.Jan 30 2020, 10:59 PM
This revision was automatically updated to reflect the committed changes.