Correctly save shortcuts of new Items
ClosedPublic

Authored by davidre on Jan 19 2020, 1:35 PM.

Details

Summary

When saving first all changes are saved before updating syscoca. This lead to a
crash because serviceByStorageId failed. We can just change the API to directly to
take KService::Ptr's.
BUG: 415699
FIXED-IN: 5.18.0

Test Plan

Correctly created a new item and set a shortcut for it

Diff Detail

Repository
R103 KMenu Editor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Jan 19 2020, 1:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2020, 1:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.Jan 19 2020, 1:35 PM
davidedmundson accepted this revision.Jan 19 2020, 4:31 PM
This revision is now accepted and ready to land.Jan 19 2020, 4:31 PM
davidre edited the summary of this revision. (Show Details)Mon, Jan 20, 1:50 PM
davidre updated this revision to Diff 73942.Mon, Jan 20, 1:51 PM

Now based on 5.18 branch

This revision was automatically updated to reflect the committed changes.