Differential D2669

Set offscreen highlight item to invisible when off screen or not being shown
ClosedPublic
Actions

Authored by davidedmundson on Sep 6 2016, 8:37 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Summary

Gammaray showed a warning about us having a visible item off screen.
This is obviously a waste of resources, and a bit weird.

We also still had the highlight visible after the drag had finished, just with an
opacity of 0.

Test Plan

Started plasma, moved a plasmoid about, highlight still worked correctly.

Diff Detail

Repository
R119 Plasma Desktop
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 6462.Sep 6 2016, 8:37 AM
davidedmundson retitled this revision from to Set offscreen highlight item to invisible when off screen or not being shown.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 6 2016, 8:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Sep 6 2016, 8:44 AM

Grepping showed AppletAppearance and AppletHandle also mess with the placeHolderPaint opacity, most likely breaking your binding

broulik accepted this revision.Sep 6 2016, 8:44 AM
broulik added a reviewer: broulik.

Err, nevermind, you didn't add a binding to "opacity" but "visible"

This revision is now accepted and ready to land.Sep 6 2016, 8:44 AM

Revision Contents
Changeset List

Diff 6462

View Options

containments/desktop/package/contents/ui/main.qml

Loading...