Don't pass window to KNotification
ClosedPublic

Authored by nicolasfella on Sun, Jan 12, 5:09 PM.

Details

Summary

It doesn't do anything useful and will be removed

Test Plan

builds

Diff Detail

Repository
R186 Choqok
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Sun, Jan 12, 5:09 PM
nicolasfella created this revision.

By passing the widget we set the notification parent to choqokMainWindow. Why is this a bad thing?

We are working on getting rid of QtWidgets in KNotifications so this constructor will disappear. There are some use-cases for having a parent widget left (like CloseWhenWidgetActivated), but none of them apply here.

scarpino accepted this revision.Tue, Jan 14, 1:25 PM
This revision is now accepted and ready to land.Tue, Jan 14, 1:25 PM
This revision was automatically updated to reflect the committed changes.