It doesn't do anything useful and will be removed
Details
Details
- Reviewers
scarpino - Group Reviewers
Choqok - Commits
- R186:435df2b76807: Don't pass window to KNotification
builds
Diff Detail
Diff Detail
- Repository
- R186 Choqok
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
By passing the widget we set the notification parent to choqokMainWindow. Why is this a bad thing?
Comment Actions
We are working on getting rid of QtWidgets in KNotifications so this constructor will disappear. There are some use-cases for having a parent widget left (like CloseWhenWidgetActivated), but none of them apply here.